[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Fix tests for VS2005

From: Branko Čibej <brane_at_xbc.nu>
Date: 2005-12-06 02:35:08 CET

Malcolm Rowe wrote:
> On Fri, Dec 02, 2005 at 06:45:49PM -0700, D.J. Heap wrote:
>
>>> This issue, IMO, is a total bug in VS2005 but MS is saying it is 'by
>>> design'. They have broken wildcard quoting in setargv.obj:
>>>
>>> http://lab.msdn.microsoft.com/ProductFeedback/viewfeedback.aspx?feedbackid=1c569ad8-7329-4d95-8588-ad6ed08fe988
>>>
>> So, due to MS' change in wildcard handling, a few tests fail when
>> Subversion is built with VS2005. This patch changes the tests that
>> use wildcards in property values to use the -F option rather than pass
>> the wildcard directly on the commandline (because VS2005 will always
>> expand it).
>>
>> I don't see a need to do anything more (such as expand wildcards
>> ourselves on Win32 or change the property-present-character from * to
>> something else) because it only affects passing * or ? in as a
>> property value and is easy to workaround using the -F option...
>>
>>
>
> I take it that this (VS2005) change also breaks setting the svn:executable
> (etc) properties like this (because they have a canonical value of '*')?
>
Not at all. For boolean props such as svn:executable, we assert the
value to '*' regardless of the value actually passed to the client. You
can write "svn propset svn:executable fooblartybar baz.sh", and still
end up with the prop's value being an asterisk.

> Is there any reason we can't distribute and compile against the VS2003
> version of setargv.obj when we're compiling with VS2005?
>
If and when we get to using a newer MS compiler for the distros, I'd
much prefer that we write the globbing code ourselves. That way we'll at
least get consistent and documentable quoting rules.

-- Brane

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Dec 6 02:35:59 2005

This is an archived mail posted to the Subversion Dev mailing list.