[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Fix tests for VS2005

From: Malcolm Rowe <malcolm-svn-dev_at_farside.org.uk>
Date: 2005-12-03 11:40:54 CET

On Fri, Dec 02, 2005 at 06:45:49PM -0700, D.J. Heap wrote:
> > This issue, IMO, is a total bug in VS2005 but MS is saying it is 'by
> > design'. They have broken wildcard quoting in setargv.obj:
> >
> > http://lab.msdn.microsoft.com/ProductFeedback/viewfeedback.aspx?feedbackid=1c569ad8-7329-4d95-8588-ad6ed08fe988
>
>
> So, due to MS' change in wildcard handling, a few tests fail when
> Subversion is built with VS2005. This patch changes the tests that
> use wildcards in property values to use the -F option rather than pass
> the wildcard directly on the commandline (because VS2005 will always
> expand it).
>
> I don't see a need to do anything more (such as expand wildcards
> ourselves on Win32 or change the property-present-character from * to
> something else) because it only affects passing * or ? in as a
> property value and is easy to workaround using the -F option...
>

I take it that this (VS2005) change also breaks setting the svn:executable
(etc) properties like this (because they have a canonical value of '*')?

Is there any reason we can't distribute and compile against the VS2003
version of setargv.obj when we're compiling with VS2005?

Regards,
Malcolm

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Dec 3 11:42:31 2005

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.