[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

[PATCH] Fix tests for VS2005

From: D.J. Heap <djheap_at_gmail.com>
Date: 2005-12-03 02:45:49 CET

> This issue, IMO, is a total bug in VS2005 but MS is saying it is 'by
> design'. They have broken wildcard quoting in setargv.obj:
>
> http://lab.msdn.microsoft.com/ProductFeedback/viewfeedback.aspx?feedbackid=1c569ad8-7329-4d95-8588-ad6ed08fe988

So, due to MS' change in wildcard handling, a few tests fail when
Subversion is built with VS2005. This patch changes the tests that
use wildcards in property values to use the -F option rather than pass
the wildcard directly on the commandline (because VS2005 will always
expand it).

I don't see a need to do anything more (such as expand wildcards
ourselves on Win32 or change the property-present-character from * to
something else) because it only affects passing * or ? in as a
property value and is easy to workaround using the -F option...

If there are no objections, I'll commit it in a day or two.

Log message:

Fix tests on Win32 when building with VS2005.

* subversion/tests/svn/revert_tests.py
  (revert_replacement_with_props): Changed propset to use -F option.

* subversion/tests/svn/copy_tests.py
  (copy_replace_with_props): Ditto.

* subversion/tests/svn/stat_tests.py:
  (status_for_unignored_file): Ditto.

DJ

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Received on Sat Dec 3 02:46:50 2005

This is an archived mail posted to the Subversion Dev mailing list.