On 11/26/05, Malcolm Rowe <email@example.com> wrote:
> On Fri, Nov 25, 2005 at 10:12:51PM +0100, Erik Huelsmann wrote:
> In addition to what Julian said,
> > + * The working copy text bases and repository files are stored
> > + * in normal form if they have any svn: properties set which
> > + * require translation.
> I really think it would be better to say that the working copy text-base
> and repository files are _always_ stored in normal form, even if the
> normal form for some of those files is 'no change'. The reason is
> that we always want callers to translate files to and from normal form
> as appropriate, rather than have them attempt to guess whether the
> translation is required or not.
Well, there is a function (svn_subst_translation_required) which will
tell them when it is, leaving no room for guessing, but, you're right
it should always be used. Changed.
> > -/** Set @a *xlated_path to a path to translated copy of @src
> > +/** Set @a *xlated_path to a path to a translated copy of @src
> > * or to @a src itself if no translation is necessary.
> I think "Set @a *xlated_path to a translated copy of @a src or..." should
> be fine (ditch 'to a path to', and s/@src/@a src).
Thanks for the review!
Received on Sun Nov 27 20:35:57 2005