[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Doc string update for (de)translation

From: Malcolm Rowe <malcolm-svn-dev_at_farside.org.uk>
Date: 2005-11-26 18:39:26 CET

On Fri, Nov 25, 2005 at 10:12:51PM +0100, Erik Huelsmann wrote:

In addition to what Julian said,

> + * The working copy text bases and repository files are stored
> + * in normal form if they have any svn: properties set which
> + * require translation.

I really think it would be better to say that the working copy text-base
and repository files are _always_ stored in normal form, even if the
normal form for some of those files is 'no change'. The reason is
that we always want callers to translate files to and from normal form
as appropriate, rather than have them attempt to guess whether the
translation is required or not.

> -/** Set @a *xlated_path to a path to translated copy of @src
> +/** Set @a *xlated_path to a path to a translated copy of @src
> * or to @a src itself if no translation is necessary.

I think "Set @a *xlated_path to a translated copy of @a src or..." should
be fine (ditch 'to a path to', and s/@src/@a src).

Regards,
Malcolm

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Nov 26 18:40:32 2005

This is an archived mail posted to the Subversion Dev mailing list.