[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r16158 - trunk/subversion/mod_dav_svn

From: <kfogel_at_collab.net>
Date: 2005-09-20 07:49:59 CEST

Ben Collins-Sussman <sussman@red-bean.com> writes:
> >> +static const char *dav_svn_list_parentpath_cmd(cmd_parms *cmd,
> >> void *config,
> >> + int arg)
> >> +{
> >> + dav_svn_dir_conf *conf = config;
> >> +
> >> + if (arg)
> >> + conf->list_parentpath = DAV_SVN_FLAG_ON;
> >> + else
> >> + conf->list_parentpath = DAV_SVN_FLAG_OFF;
> >> +
> >> + return NULL;
> >> +}
> >
> > Something tells me this function implements an interface type defined
> > by Apache HTTPD :-). If so, a short doc string should say that type's
> > name.
>
> It's cut-and-paste imitative of several functions in mod_dav_svn.c,
> absolutely none of which are documented. Maybe we should add
> docstrings to all of them...?

Well, that would be ideal, sure :-). But if not, we can at least not
perpetuate our past sins in new code.

-Karl

-- 
www.collab.net  <>  CollabNet  |  Distributed Development On Demand
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Sep 20 08:55:53 2005

This is an archived mail posted to the Subversion Dev mailing list.