[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r16158 - trunk/subversion/mod_dav_svn

From: Ben Collins-Sussman <sussman_at_red-bean.com>
Date: 2005-09-20 07:03:51 CEST

On Sep 19, 2005, at 8:32 PM, kfogel@collab.net wrote:

> sussman@tigris.org writes:
>
>> --- trunk/subversion/mod_dav_svn/mod_dav_svn.c (original)
>> +++ trunk/subversion/mod_dav_svn/mod_dav_svn.c Mon Sep 19
>> 08:28:15 2005
>> @@ -187,6 +190,20 @@
>> }
>>
>>
>> +static const char *dav_svn_list_parentpath_cmd(cmd_parms *cmd,
>> void *config,
>> + int arg)
>> +{
>> + dav_svn_dir_conf *conf = config;
>> +
>> + if (arg)
>> + conf->list_parentpath = DAV_SVN_FLAG_ON;
>> + else
>> + conf->list_parentpath = DAV_SVN_FLAG_OFF;
>> +
>> + return NULL;
>> +}
>>
>
> Something tells me this function implements an interface type defined
> by Apache HTTPD :-). If so, a short doc string should say that type's
> name.

It's cut-and-paste imitative of several functions in mod_dav_svn.c,
absolutely none of which are documented. Maybe we should add
docstrings to all of them...?

>
> Why not just
>
> return get_parentpath_resource(r, root_path, resource);
>
> at the end there?

Doh, of course!

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Sep 20 07:04:47 2005

This is an archived mail posted to the Subversion Dev mailing list.