[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] truncate EDITOR_EOF_PREFIX with previous EOL

From: Julian Foad <julianfoad_at_btopenworld.com>
Date: 2005-07-22 20:52:56 CEST

kfogel@collab.net wrote:
> Julian Foad <julianfoad@btopenworld.com> writes:
>>Olleg, I agree with you that the behaviour is odd and unpleasant and
>>seems to be wrong. I also would like the program to remove trailing
>>whitespace, either when creating or when displaying the log message.
> I am totally, completely opposed to Subversion taking the trailing
> newline off my log messages. Take my house, take my car, take my
> piano (well, no, leave the piano please) but DO NOT TAKE my trailing
> newline.
> Thank you :-).

That's fine - I don't want your trailing newline anyway, I'd much prefer your
piano. Hmm... That'll teach me not to respond in such imprecise terms to a
thread whose aims and arguments are already confused and whose contributors are
already misunderstanding each other.

Actually, I don't particularly want the final newline character to be removed.
  What I meant was primarily that I really do not want the display from "svn
log" to have _extra_ visible whitespace (i.e. an extra blank line).
Secondarily, I wouldn't mind if all trailing spaces and/or blank lines were
removed when the "This line and below..." stuff is removed, although I can now
see and accept why you wouldn't want that; and I would also feel more
comfortable if the internal storage of the log messages would have consistent
line ending conventions (all messages ending with a newline character, or all
not doing so).

Removing any final newline character would make the log messages be consistent
with the log messages that are typically entered on the command line in a
quoted string argument to "-m", where the user doesn't generally add a literal
newline character before closing the string, but I generally consider a "line"
to be incomplete without its terminating newline control character. Thus I
might prefer to have "svn" add a newline character to any provided log message
if it is missing.

But these specific ideas for specific behaviours are, I think, pretty much moot
at this time. All I was trying to do was to show some understanding and
support for the original poster, because all other respondents seemed to be
shooting him down with statements and technical details that didn't closely
relate to the user experience.

>>>>Well, you didn't write one line :-). You wrote a line, followed by a
>>>> newline, followed by a line that promised its own removal at
>>>>commit time, along with everything following it. And that's
>>>>exactly what happens right now.
>>(Well, Karl, that's unfair, and you know it!)
> Uh, no, I meant it seriously.

Sorry, I didn't mean to get your back up. Unfortunately I think your use of
the word "wrote" just fanned the flames.

> The user has left a message in the
> buffer that can be interpreted multiple ways, Subversion has to make a
> choice. [...]

That's the thing: he left extra stuff in the buffer that he didn't write. To
me it was obvious that Olleg was speaking as a user when he said he wrote one
line. The fact that the system (svn and the editor) conspired to add a newline
character and further lines of text to what he wrote, and feed the whole lot
back into svn, is an aspect of the technical operation that merely detracted
attention from what he actually wrote.

- Julian

To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Jul 22 20:54:04 2005

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.