Re: [PATCH] truncate EDITOR_EOF_PREFIX with previous EOL

Julian Foad wrote:
> We can argue that making log messages end consistently would be better
> for us, but another Subversion user might want to retrieve the log
> message and feed it back into the editor that created it; if Subversion
> had altered the ending, that might give unpleasant results. So, there
> is no single behaviour that everyone can agree is the correct behaviour.

At current moment EOL at the end is not guarantied. It is only arised in
some cases. Nobody can expect EOL at the end always. And the "another
Subversion user" must keep it in mind.

>> There is chose. Rewrite almost code to support log message with
>> trailing EOL, as Greg like. Or fix bug. Or do nothing? What your prefer?
>
> ("There is a choice.")

Thank you. You undestand me even in a wrong phrase. :-)

> Unfortunately for you and me, I think in this situation the best thing
> is to do nothing at the moment. In version 2 of the Subversion
> command-line client, we could do something different. Other clients,
> such as TortoiseSVN, can do something different.

Yes, of cause. But. Now there are two variant of existance an one line
message. One of them wrong, isn't it? Why we can't fix it now?

>> IMHO, will be convenient remove all white spaces at the end, not only
>> EOL. They arised by mistype usually. Don't have any useful
>> information. And invisible for human to fix it manualy.
>
> Yes, I agree. I would like to use a client that removes all trailing
> white space (or replaces it with a single newline control code). I
> wrote my own patch last year to do this in a different way, and (IIRC)
> it also was rejected by the Subversion team. We will just have to get
> used to it, or use a patched or different client program to display the
> log messages.

Simplest way write hook script or use only "svn commit --message".

I am surprised by policy of applying patches too. Is here something like
"Debian Technical Committee"? Or all decisions maded by folks form
collab.net?

-- 
Olleg Samoylov
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org