[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] truncate EDITOR_EOF_PREFIX with previous EOL

From: <kfogel_at_collab.net>
Date: 2005-07-22 17:40:14 CEST

Julian Foad <julianfoad@btopenworld.com> writes:
> Olleg, I agree with you that the behaviour is odd and unpleasant and
> seems to be wrong. I also would like the program to remove trailing
> whitespace, either when creating or when displaying the log message.

I am totally, completely opposed to Subversion taking the trailing
newline off my log messages. Take my house, take my car, take my
piano (well, no, leave the piano please) but DO NOT TAKE my trailing
newline.

Thank you :-).

> >> Well, you didn't write one line :-). You wrote a line, followed by a
> >> newline, followed by a line that promised its own removal at
> >> commit time, along with everything following it. And that's
> >> exactly what happens right now.
>
> (Well, Karl, that's unfair, and you know it!)

Uh, no, I meant it seriously. The user has left a message in the
buffer that can be interpreted multiple ways, Subversion has to make a
choice. But note that the actual *promise* being made by this:

    --This line, and those below, will be ignored--

is merely that that line, and those below it, would be ignored. The
newline that ends the preceding line is not (usually, IMHO) considered
part of the next line, it is considered the last character of the
preceding line. So right now, we're keeping the promise. If we
remove that newline, we're doing more than we said we would. I'd call
*that* a bug, if anything.

> > IMHO, will be convenient remove all white spaces at the end, not
> > only EOL. They arised by mistype usually. Don't have any useful
> > information. And invisible for human to fix it manualy.

This assertion that they usually arise by mistype is unverifiable.
When I commit them, they are deliberate, and look over the Subversion
logs -- I almost always *do* commit them.

(By the way, this response doesn't violate my promise not to respond
again unless someone said something new. Julian did say something
new: he proposed to take away my grand piano! :-) )

-Karl

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Jul 22 18:31:55 2005

This is an archived mail posted to the Subversion Dev mailing list.