[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: libsvn_repos logging -- design problems

From: <kfogel_at_collab.net>
Date: 2005-07-15 20:45:31 CEST

Branko Čibej <brane@xbc.nu> writes:
> Greg Hudson wrote:
> >My advice is to ignore Branko's concern until it becomes an issue; when
> >it does, we can optimize performance in successive steps by (1) querying
> >the log level to avoid creating arguments, and (2) caching the log level
> >to avoid making any function calls.
>
> And what about changing a bunch of code to do (1)? Why don't we just
> trust my experience for once and go straight for (1), because (1)->(2)
> is likely to be a less intrusive change.

Huh, we trust your experience on things all the time, so I dunno where
that "for once" comes from :-).

Greg: I'm not sure why you don't want to follow Brane's advice on
this. The macro is easy to write, it ensures we won't ever have that
problem, and it's no harder to use. Seems like a win all around. Am
I missing something?

Premature optimization doesn't feel particularly sinful when a) it
doesn't impose much coding overhead, and b) it's based on real-world
experience anyway. I call that "mature optimization"...

-K

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Jul 15 21:35:22 2005

This is an archived mail posted to the Subversion Dev mailing list.