[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: libsvn_repos logging -- design problems

From: Branko Čibej <brane_at_xbc.nu>
Date: 2005-07-15 19:10:14 CEST

Greg Hudson wrote:

>On Fri, 2005-07-15 at 10:23 -0500, Ben Collins-Sussman wrote:
>
>
>> The logging API can still do the loglevel-test, but server
>> processes should cache the repository's loglevel and avoid
>> constructing messages when they can. This can be documented as a
>> 'best practice', or we can create a macro like branko demonstrated.
>>
>>
>
>My advice is to ignore Branko's concern until it becomes an issue; when
>it does, we can optimize performance in successive steps by (1) querying
>the log level to avoid creating arguments, and (2) caching the log level
>to avoid making any function calls.
>
>
And what about changing a bunch of code to do (1)? Why don't we just
trust my experience for once and go straight for (1), because (1)->(2)
is likely to be a less intrusive change.

-- Brane

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Jul 15 19:11:16 2005

This is an archived mail posted to the Subversion Dev mailing list.