[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: libsvn_repos logging -- design problems

From: Branko Čibej <brane_at_xbc.nu>
Date: 2005-07-16 01:01:30 CEST

kfogel@collab.net wrote:

>Branko Čibej <brane@xbc.nu> writes:
>
>
>>Greg Hudson wrote:
>>
>>
>>>My advice is to ignore Branko's concern until it becomes an issue; when
>>>it does, we can optimize performance in successive steps by (1) querying
>>>the log level to avoid creating arguments, and (2) caching the log level
>>>to avoid making any function calls.
>>>
>>>
>>And what about changing a bunch of code to do (1)? Why don't we just
>>trust my experience for once and go straight for (1), because (1)->(2)
>>is likely to be a less intrusive change.
>>
>>
>
>Huh, we trust your experience on things all the time, so I dunno where
>that "for once" comes from :-).
>
>
Well, Greg always seems to disagree with me on issues like this one. :)

>Greg: I'm not sure why you don't want to follow Brane's advice on
>this. The macro is easy to write, it ensures we won't ever have that
>problem, and it's no harder to use. Seems like a win all around. Am
>I missing something?
>
>
You're not.

And I find the statement that my "experience is specific to a particular
system, with a particular set of tracing calls added in" slightly
amusing. I've had my fingers in all sorts of server applications, from
web services through Unix-based file servers to Windows filesystem
drivers, have used serveral tracing libraries on each, and have observed
the behaviour I described in every single case.

I'm all for avoiding premature optimisation, in general. In this
particular case, a very small , low-risk investment can bring huge
benefits in the long run.

-- Brane

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Jul 16 01:02:59 2005

This is an archived mail posted to the Subversion Dev mailing list.