Re: [PATCH] libsvn_repos logging API -- 2nd draft

On Fri, 15 Jul 2005, Ben Collins-Sussman wrote:

> +/** The different "levels" of messages that can go into a repository's
> + errorlog. */
> +typedef enum
> +{
> + /** A real error happened */
> + svn_repos_loglevel_error = 1,
> +
> + /** No error, but something that might be of concern */
> + svn_repos_loglevel_warning = 5,
> +
> + /** Message only interesting to svn developers */
> + svn_repos_loglevel_debug = 10
> +
> +} svn_repos_loglevel_t;

That doesn't look spread enough to me.
Quoting the syslog manpage:

 LOG_EMERG system is unusable
 LOG_ALERT action must be taken immediately
 LOG_CRIT critical conditions
 LOG_ERR error conditions
 LOG_WARNING warning conditions
 LOG_NOTICE normal, but significant, condition
 LOG_INFO informational message
 LOG_DEBUG debug-level message

Maybe you want to start with svn_repos_loglevel_error = 5 just in case a
level for a more critical error condition is needed, like f.ex. that "bdb
recovery is needed" error.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Jul 15 19:14:24 2005