[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: libsvn_repos logging -- design problems

From: Greg Hudson <ghudson_at_MIT.EDU>
Date: 2005-07-15 20:43:12 CEST

On Fri, 2005-07-15 at 19:10 +0200, Branko Čibej wrote:
> >My advice is to ignore Branko's concern until it becomes an issue; when
> >it does, we can optimize performance in successive steps by (1) querying
> >the log level to avoid creating arguments, and (2) caching the log level
> >to avoid making any function calls.

> And what about changing a bunch of code to do (1)? Why don't we just
> trust my experience for once and go straight for (1), because (1)->(2)
> is likely to be a less intrusive change.

Because your experience is specific to a particular system, with a
particular set of tracing calls added in. At least initially, we'll be
adding very simple logging (no complex argument production) of
large-grain operations which will take many orders of magnitude more
resources than the logging itself. So, overengineering for performance
is not warranted yet.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Jul 15 20:44:53 2005

This is an archived mail posted to the Subversion Dev mailing list.