[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r15043 - trunk/subversion/clients/cmdline

From: Daniel Rall <dlr_at_finemaltcoding.com>
Date: 2005-06-13 20:18:05 CEST

On Mon, 2005-06-13 at 12:43 -0500, julianfoad@tigris.org wrote:
>Author: julianfoad
>Date: Mon Jun 13 12:43:02 2005
>New Revision: 15043
...
>--- trunk/subversion/clients/cmdline/add-cmd.c (original)
>+++ trunk/subversion/clients/cmdline/add-cmd.c Mon Jun 13 12:43:02 2005
...
>@@ -63,19 +62,14 @@
>
> svn_pool_clear (subpool);
> SVN_ERR (svn_cl__check_cancel (ctx->cancel_baton));
>- err = svn_client_add3 (target, (! opt_state->nonrecursive),
>- opt_state->force, opt_state->no_ignore,
>- ctx, subpool);
>- if (err)
>- {
>- if (err->apr_err == SVN_ERR_ENTRY_EXISTS)
>- {
>- svn_handle_warning (stderr, err);
>- svn_error_clear (err);
>- }
>- else
>- return err;
>- }
>+ SVN_ERR (svn_cl__try
>+ (svn_client_add3 (target, (! opt_state->nonrecursive),
>+ opt_state->force, opt_state->no_ignore,
>+ ctx, subpool),
>+ NULL, opt_state->quiet,
>+ SVN_ERR_ENTRY_EXISTS,
>+ SVN_ERR_WC_PATH_NOT_FOUND,
>+ SVN_NO_ERROR));
> }

Is there any particular reason that the last five parameters use up so
much vertical space? Seems like they could be compressed to only a
couple of lines.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Jun 13 20:20:31 2005

This is an archived mail posted to the Subversion Dev mailing list.