[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r15043 - trunk/subversion/clients/cmdline

From: <kfogel_at_collab.net>
Date: 2005-06-14 00:43:54 CEST

Daniel Rall <dlr@finemaltcoding.com> writes:
> >+ SVN_ERR (svn_cl__try
> >+ (svn_client_add3 (target, (! opt_state->nonrecursive),
> >+ opt_state->force, opt_state->no_ignore,
> >+ ctx, subpool),
> >+ NULL, opt_state->quiet,
> >+ SVN_ERR_ENTRY_EXISTS,
> >+ SVN_ERR_WC_PATH_NOT_FOUND,
> >+ SVN_NO_ERROR));
> > }
>
> Is there any particular reason that the last five parameters use up so
> much vertical space? Seems like they could be compressed to only a
> couple of lines.

I might be guilty of starting, or at least perpetuating, this trend.

I like this style for varargs lists, because it makes it visually
clear that this is a series of objects that are semantically "on the
same level", terminated with a special object. Actually the style is:
first try to fit them all on one line (including the terminator), and
if that doesn't work, then write them out one-per-line -- unless the
*only* arguments to the function are varargs, in which case just
mooshing them together into a normal arguments blob is fine, because
there are no other sorts of arguments from which they need to be
distinguished.

You know, I don't think I've ever had to articulate this before.

-Karl

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Jun 14 01:26:43 2005

This is an archived mail posted to the Subversion Dev mailing list.