[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r15043 - trunk/subversion/clients/cmdline

From: Julian Foad <julianfoad_at_btopenworld.com>
Date: 2005-06-13 20:29:12 CEST

Daniel Rall wrote:
>>+ SVN_ERR (svn_cl__try
>>+ (svn_client_add3 (target, (! opt_state->nonrecursive),
>>+ opt_state->force, opt_state->no_ignore,
>>+ ctx, subpool),
>>+ NULL, opt_state->quiet,
>>+ SVN_ERR_ENTRY_EXISTS,
>>+ SVN_ERR_WC_PATH_NOT_FOUND,
>>+ SVN_NO_ERROR));
>
> Is there any particular reason that the last five parameters use up so
> much vertical space? Seems like they could be compressed to only a
> couple of lines.

It's already been done like that in the other three calls to svn_cl__try. I'm
not inclined to change it now.

- Julian

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Jun 13 20:30:35 2005

This is an archived mail posted to the Subversion Dev mailing list.