[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] make add skip unversioned res..V2

From: Julian Foad <julianfoad_at_btopenworld.com>
Date: 2005-06-13 19:57:28 CEST

vivek@collab.net wrote:
> [[[
> Use svn_cl__try for skipping non-fatal errors.
>
> * subversion/clients/cmdline/add-cmd.c
> (svn_cl__add): Removed the variable err, use svn_cl__try.
> ]]]

The most important thing to document in the log message is the functional
change: treating nonexistent paths as warnings rather than errors. Then the
use of svn_cl__try, which is perhaps a noteworthy implementation detail. The
removal of any local variables that are unused because of the change is
implicit, so not worth mentioning.

Also, this should say that it is related to issue #2030: "Errorful targets
should be skipped, not end the entire operation", as that explains why the
change is wanted.

So:

[[[
Make "svn add" skip nonexistent items with a warning. Use svn_cl__try to
simplify the handling of warnings. This is part of issue #2030: "Errorful
targets should be skipped, not end the entire operation".

* subversion/clients/cmdline/add-cmd.c
   (svn_cl__add): Warn if path not found; use svn_cl__try.
]]]

As far as I can see, the patch is fine (though the patch file unexpectedly ends
in the middle of a line). I've tested it by hand.

Committed with this log message in r15043.

Thanks for the patch.

- Julian

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Jun 13 19:58:51 2005

This is an archived mail posted to the Subversion Dev mailing list.