[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: proposal: diff preview for gui client

From: Martin Hauner <Martin.Hauner_at_gmx.net>
Date: 2005-06-09 09:02:23 CEST

Julia Foad wrote:
> Martin Hauner wrote:
> > This is about getting a usable gui interface for diffs between urls
> > like tags or branches.
>
> > typedef struct svn_diff_preview_t
> > {
> > /** file or dir */
> > svn_node_kind_t node_kind;
> >
> > /** item paths, relative to the old diff target and new diff target */
> > const char* path_old;
> > const char* path_new;
> >
> > /** the mime types of old and new */
> > const char *mimetype_old,
> > const char *mimetype_new,
>
> For a directory, I suppose these would both be null?

Yes.

> >
> > /** change kind: unchanged, added, modified or deleted */
> > svn_preview_kind_t preview_kind;
>
> For a file, I suppose this would refer to its content? That would
> address Steve King's request for a "text_changed" field.
>
> For a directory, what exactly would this field mean?

Yes, for files it is meant for the content.

For a folder this would be:

1. unchanged if there are only property changes or
2. added if added
3. deleted if deleted

> > /** properties changed? */
> > svn_boolean_t props_changed;
> >
> > } svn_diff_preview_t;
>
>
> Apart from those details, the next stage is to work out how the
> client and server need to interact to provide this information,
> and whether new server protocol elements etc. are needed in order
> to get the result efficiently. If so, consider also backward
> compatibility.

oh..

> Of course, you could just implement this crudely on the client side to
> begin with, and leave the efficient implementation as a later task. I
> don't know if people would think that was worthwhile.

.. i thought this would be client side only. I am able to provide a
client side patch. I would like to get a few pointers where to look at
the code if this involves client/server communication.

I don't speak native subversion. ;-)

-- 
Martin
Subcommander, http://subcommander.tigris.org
a crossplatform Win32/Unix/MacOSX svn gui client & diff/merge tool.
Weitersagen: GMX DSL-Flatrates mit Tempo-Garantie!
Ab 4,99 Euro/Monat: http://www.gmx.net/de/go/dsl
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Jun 9 09:05:11 2005

This is an archived mail posted to the Subversion Dev mailing list.