[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: proposal: diff preview for gui client

From: Julian Foad <julianfoad_at_btopenworld.com>
Date: 2005-06-09 00:50:56 CEST

Martin Hauner wrote:
> on Julians request I retry to gather the requirements for the gui
> diff preview. I don't consider diff summarize here so we don't mix
> the requirements between the two issues.
>
> I hope this helps to make some progress on this issue. :)

Thanks, Martin. This is an excellent proposal: exactly the level of detail
that I was looking for.

> This is about getting a usable gui interface for diffs between urls
> like tags or branches.

> typedef struct svn_diff_preview_t
> {
> /** file or dir */
> svn_node_kind_t node_kind;
>
> /** item paths, relative to the old diff target and new diff target */
> const char* path_old;
> const char* path_new;
>
> /** the mime types of old and new */
> const char *mimetype_old,
> const char *mimetype_new,

For a directory, I suppose these would both be null?

>
> /** change kind: unchanged, added, modified or deleted */
> svn_preview_kind_t preview_kind;

For a file, I suppose this would refer to its content? That would address
Steve King's request for a "text_changed" field.

For a directory, what exactly would this field mean?

>
> /** properties changed? */
> svn_boolean_t props_changed;
>
> } svn_diff_preview_t;

Apart from those details, the next stage is to work out how the client and
server need to interact to provide this information, and whether new server
protocol elements etc. are needed in order to get the result efficiently. If
so, consider also backward compatibility.

Of course, you could just implement this crudely on the client side to begin
with, and leave the efficient implementation as a later task. I don't know if
people would think that was worthwhile.

- Julian

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Jun 9 00:51:57 2005

This is an archived mail posted to the Subversion Dev mailing list.