[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Subversion 1.2.0 RC3 (final candidate) on Monday?

From: Peter N. Lundblad <peter_at_famlundblad.se>
Date: 2005-05-08 13:12:37 CEST

On Sun, 8 May 2005, Patrick Mayweg wrote:

> I have researched the problem in detail. The java executable on windows
> uses just 256KB of stack size instead of the default 1MB stack size. In
> this situation putting buffers of 100KB (SVN_STREAM_CHUNK_SIZE) becomes
> a problem. There are some functions putting 1 or 2 buffers on the stack.
> Other functions getting this kind of buffer space from an apr pool. To
> solve Marks problem, we could either reduce the buffer size to 90KB or
> take the space from the pool. Since both ways are out of my commit
> area, I would like to have some input, which way to go for working out a
> patch.

Ouch! Putting vars of those sizes on the stack isn't very friendly. Just
allocate it out of a pool instead.

(Saying this without having investigated in detail, but I can't imagine it
should be a problem.)

Thanks,
//Peter

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sun May 8 13:05:05 2005

This is an archived mail posted to the Subversion Dev mailing list.