[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Subversion 1.2.0 RC3 (final candidate) on Monday?

From: Patrick Mayweg <mayweg_at_qint.de>
Date: 2005-05-08 12:36:56 CEST

Hi Mark,
I have researched the problem in detail. The java executable on windows
uses just 256KB of stack size instead of the default 1MB stack size. In
this situation putting buffers of 100KB (SVN_STREAM_CHUNK_SIZE) becomes
a problem. There are some functions putting 1 or 2 buffers on the stack.
Other functions getting this kind of buffer space from an apr pool. To
solve Marks problem, we could either reduce the buffer size to 90KB or
take the space from the pool. Since both ways are out of my commit
area, I would like to have some input, which way to go for working out a
patch.
Regards,
Patrick

Mark Phippard wrote:

>kfogel@collab.net wrote on 05/06/2005 02:57:57 PM:
>
>
>
>>What would we say to rolling rc3 on Monday? Ben Reser, does that work
>>for you? That would give us the weekend to vote on pending STATUS
>>items (of which there are currently 10, but only 2 or 3 have any
>>complexity to them).
>>
>>Assuming no showstoppers, rc3 would be the final candidate,
>>essentially identical to 1.2.0, which would be released one week
>>later. Of course, were we to find a bug in rc3 severe enough to
>>warrant rc4, that would re-start the 1-week resoak.
>>
>>
>
>I guess it is not a show stopper, but recall that I have a pending issue
>that merge over http:// from the JavaHL binding crashes the JVM on
>Windows. Patrick Mayweg is planning to look at it when he gets home from
>vacation this weekend. He did some preliminary checking and this looks
>like it might be a tough problem to solve. The issue is that Java uses a
>really small stack size on Windows and there is no reasonable way to alter
>it or control it. Some changes in the merge API have apparently caused
>the stack usage to exceed this limit. Unless there is some way to compile
>the JavaHL DLL so that it allocates all memory from the heap, I do not
>know how this could be fixed.
>
>Hopefully Patrick will find some clever solution.
>
>Just wanted you to be aware of it. I am really not sure what we are doing
>to do about this in Subclipse. It is pretty nasty to just crash the
>user's IDE.
>
>Mark
>
>
>_____________________________________________________________________________
>Scanned for SoftLanding Systems, Inc. by IBM Email Security Management Services powered by MessageLabs.
>_____________________________________________________________________________
>
>---------------------------------------------------------------------
>To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
>For additional commands, e-mail: dev-help@subversion.tigris.org
>
>
>

iconv_getpathname(char * 0x00049708, const char * 0x6ee56fac, const char * 0x000476dc, apr_pool_t * 0x035cbbf0) line 59 + 23 bytes
iconv_getpath(char * 0x00049708, const char * 0x035bd477, apr_pool_t * 0x035bd410) line 111 + 25 bytes
apr_iconv_mod_load(const char * 0x035bd470, int 257, const void * 0x00000000, iconv_module * * 0x0004b73c, apr_pool_t * 0x035bd410) line 147 + 20 bytes
apr_iconv_ces_open(const char * 0x035bd470, iconv_ces * * 0x03517328, apr_pool_t * 0x035bd410) line 47 + 24 bytes
iconv_uc_open(const char * 0x030a8168 `string', const char * 0x035bd470, void * * 0x0004b780, apr_pool_t * 0x035bd410) line 37 + 17 bytes
apr_iconv_open(const char * 0x030a8168 `string', const char * 0x035bd470, apr_pool_t * 0x035bd410, void * * 0x035bd488) line 88 + 23 bytes
apr_xlate_open(apr_xlate_t * * 0x035bd460, const char * 0x030a8168 `string', const char * 0x035bd470, apr_pool_t * 0x035bd410) line 265 + 25 bytes
get_xlate_handle_node(xlate_handle_node_t * * 0x0004b900, const char * 0x030a8168 `string', const char * 0x00000001, const char * 0x030a8100 `string', apr_pool_t * 0x035bd410) line 204 + 26 bytes
get_ntou_xlate_handle_node(xlate_handle_node_t * * 0x0004b900, apr_pool_t * 0x035bd410) line 306 + 25 bytes
svn_utf_cstring_to_utf8(const char * * 0x0004b970, const char * 0x0004b974, apr_pool_t * 0x035bd410) line 658 + 13 bytes
svn_error_wrap_apr(int 70014, const char * 0x030a8c8c `string') line 164 + 26 bytes
do_io_file_wrapper_cleanup(apr_file_t * 0x035a0488, int 70014, const char * 0x030a8c8c `string', const char * 0x030a8ca4 `string', apr_pool_t * 0x035a0400) line 2172 + 73 bytes
svn_io_file_read_full(apr_file_t * 0x035a0488, void * 0x0004bdd8, unsigned int 102400, unsigned int * 0x0004bdc8, apr_pool_t * 0x035a0400) line 2233 + 55 bytes
read_handler_apr(void * 0x035afc48, char * 0x0004bdd8, unsigned int * 0x0004bdc8) line 250 + 32 bytes
svn_stream_read(svn_stream_t * 0x035afc50, char * 0x0004bdd8, unsigned int * 0x0004bdc8) line 97 + 22 bytes
svn_subst_translate_stream(svn_stream_t * 0x035afc50, svn_stream_t * 0x035afc68, const char * 0x0308f69c `string', int 1, const svn_subst_keywords_t * 0x00000000, int 0) line 614 + 23 bytes
svn_subst_copy_and_translate2(const char * 0x034fa2b0, const char * 0x03584958, const char * 0x0308f69c `string', int 1, const svn_subst_keywords_t * 0x00000000, int 0, int 0, apr_pool_t * 0x03566570) line 976 + 29 bytes
svn_wc_translated_file(const char * * 0x000651f8, const char * 0x034fa2b0, svn_wc_adm_access_t * 0x035d2d08, int 1, apr_pool_t * 0x03566570) line 107 + 36 bytes
svn_wc_merge(const char * 0x034fa8b8, const char * 0x03506220, const char * 0x034fa2b0, svn_wc_adm_access_t * 0x035d2d08, const char * 0x035665a8, const char * 0x035665c0, const char * 0x03091e18 `string', int 1, int * 0x000652a4, const char * 0x00000000, apr_pool_t * 0x03566570) line 75 + 23 bytes
merge_file_changed(svn_wc_adm_access_t * 0x035d2d08, int * 0x00065370, int * 0x0006536c, const char * 0x034fa2b0, const char * 0x034fa8b8, const char * 0x03506220, long 1330, long 1331, const char * 0x00000000, const char * 0x00000000, const apr_array_header_t * 0x034fa300, apr_hash_t * 0x03505660, void * 0x0007eaf0) line 856 + 55 bytes
close_file(void * 0x034fa228, const char * 0x03559220, apr_pool_t * 0x034fa1e8) line 810 + 119 bytes
close_file(void * 0x034fa220, const char * 0x03559220, apr_pool_t * 0x034fa1e8) line 236 + 25 bytes
end_element(void * 0x038bd738, int 238, const char * 0x03555dc8, const char * 0x038cc860) line 2509 + 32 bytes
end_element(void * 0x038c8608, const char * 0x0350e515) line 361 + 51 bytes
doContent(void * 0x035539d8, int 0, const encoding * 0x030af390 utf8_encoding, const char * 0x035ececb, const char * 0x035ed6d9, const char * * 0x035539f0) line 1744 + 20 bytes
contentProcessor(void * 0x035539d8, const char * 0x035ec727, const char * 0x035ed6d9, const char * * 0x035539f0) line 1354 + 33 bytes
doProlog(void * 0x035539d8, const encoding * 0x030af390 utf8_encoding, const char * 0x035ec727, const char * 0x035ed6d9, int 29, const char * 0x035ec727, const char * * 0x035539f0) line 2692 + 21 bytes
prologProcessor(void * 0x035539d8, const char * 0x035ec700, const char * 0x035ed6d9, const char * * 0x035539f0) line 2528 + 39 bytes
prologInitProcessor(void * 0x035539d8, const char * 0x035ec700, const char * 0x035ed6d9, const char * * 0x035539f0) line 2517 + 21 bytes
XML_ParseBuffer(void * 0x035539d8, int 4057, int 0) line 1156 + 64 bytes
XML_Parse(void * 0x035539d8, const char * 0x00065754, int 4057, int 0) line 1145 + 17 bytes
ne_xml_parse(ne_xml_parser_s * 0x038c8608, const char * 0x00065754, unsigned int 4057) line 482 + 24 bytes
parse_spool_file(const char * 0x03561e18, ne_xml_parser_s * 0x038c8608, apr_pool_t * 0x0357d138) line 516 + 23 bytes
parsed_request(ne_session_s * 0x003ffbc8, const char * 0x0309870c `string', const char * 0x03561820, const char * 0x00000000, apr_file_t * 0x038bda88, void (ne_xml_parser_s *, void *)* 0x00000000, const svn_ra_dav__xml_elm_t * 0x00000000, int 0, int (void *, int, int)* 0x00000000, int (void *, const svn_ra_dav__xml_elm_t *, const char * *)* 0x00000000, ...) line 744 + 17 bytes
svn_ra_dav__parsed_request(ne_session_s * 0x003ffbc8, const char * 0x0309870c `string', const char * 0x03561820, const char * 0x00000000, apr_file_t * 0x038bda88, void (ne_xml_parser_s *, void *)* 0x00000000, int (void *, int, const char *, const char *, const char * *)* 0x02f1c050 start_element(void *, int, const char *, const char *, const char * *), ...) line 807 + 71 bytes
reporter_finish_report(void * 0x038bd738, apr_pool_t * 0x03506398) line 2803 + 74 bytes
do_merge(const char * 0x035dc369, const char * 0x00000000, const svn_opt_revision_t * 0x0007eca8, const char * 0x035d8119, const char * 0x00000000, const svn_opt_revision_t * 0x0007ec8c, const svn_opt_revision_t * 0x0007ead0, const char * 0x03595cc9, svn_wc_adm_access_t * 0x03506c60, int 1, int 0, int 1, const svn_wc_diff_callbacks2_t * 0x03091dd8 merge_callbacks, void * ...) line
svn_client_merge(const char * 0x035dc369, const svn_opt_revision_t * 0x0007eca8, const char * 0x035d8119, const svn_opt_revision_t * 0x0007ec8c, const char * 0x03595cc9, int 1, int 0, int 0, int 1, svn_client_ctx_t * 0x035064d8, apr_pool_t * 0x03506398) line 2515 + 70 bytes
SVNClient::merge(const char * 0x00a154b8, Revision & {...}, const char * 0x00a18eb8, Revision & {...}, const char * 0x00a48b00, unsigned char 0, unsigned char 1, unsigned char 0, unsigned char 1) line 1152 + 97 bytes

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sun May 8 12:37:41 2005

This is an archived mail posted to the Subversion Dev mailing list.