Re: Subversion 1.2.0 RC3 (final candidate) on Monday?

"Peter N. Lundblad" <peter@famlundblad.se> writes:

> Ouch! Putting vars of those sizes on the stack isn't very friendly. Just
> allocate it out of a pool instead.
>
> (Saying this without having investigated in detail, but I can't imagine it
> should be a problem.)

Look at this:

svn_error_t *
svn_subst_translate_stream (svn_stream_t *s, /* src stream */
                            svn_stream_t *d, /* dst stream */
                            const char *eol_str,
                            svn_boolean_t repair,
                            const svn_subst_keywords_t *keywords,
                            svn_boolean_t expand)
{
  char buf[SVN_STREAM_CHUNK_SIZE + 1];
  const char *p, *interesting;

There is no readily available pool, and neither svn_stream_t nor
svn_subst_keywords_t provides one. There is a void* baton in
svn_stream_t but svn_subst_translate_stream can't really make any
assumptions about it.

-- 
Philip Martin
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org