Re: Subversion 1.2.0 RC3 (final candidate) on Monday?

On 5/8/05, Peter N. Lundblad <peter@famlundblad.se> wrote:
> On Sun, 8 May 2005, Patrick Mayweg wrote:
>
> > I have researched the problem in detail. The java executable on windows
> > uses just 256KB of stack size instead of the default 1MB stack size. In
> > this situation putting buffers of 100KB (SVN_STREAM_CHUNK_SIZE) becomes
> > a problem. There are some functions putting 1 or 2 buffers on the stack.
> > Other functions getting this kind of buffer space from an apr pool. To
> > solve Marks problem, we could either reduce the buffer size to 90KB or
> > take the space from the pool. Since both ways are out of my commit
> > area, I would like to have some input, which way to go for working out a
> > patch.
>
> Ouch! Putting vars of those sizes on the stack isn't very friendly. Just
> allocate it out of a pool instead.

I agree - very bad stack manners.

-- 
Michael Sinz               Technology and Engineering Director/Consultant
"Starting Startups"                          mailto:Michael.Sinz@sinz.org
My place on the web                      http://www.sinz.org/Michael.Sinz
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org