[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r13866 - in trunk: contrib/client-side/svn-push subversion/include subversion/libsvn_subr subversion/svnadmin subversion/svndumpfilter subversion/svnlook subversion/svnserve subversion/svnversion subversion/tests subversion/tests/libsvn_delta subversion/tests/libsvn_diff subversion/tests/libsvn_subr tools/examples

From: Philip Martin <philip_at_codematters.co.uk>
Date: 2005-04-04 18:38:08 CEST

kfogel@collab.net writes:

> philip@tigris.org writes:
>> --- trunk/subversion/include/svn_error.h (original)
>> +++ trunk/subversion/include/svn_error.h Sat Apr 2 19:49:28 2005
>> @@ -152,17 +152,33 @@
>> void svn_error_clear (svn_error_t *error);
>>
>>
>> -/** Very basic default error handler: print out error stack, and quit
>> - * iff the @a fatal flag is set.
>> +/** @since New in 1.2
>> + *
>> + * Very basic default error handler: print out error stack @a error to the
>> + * stdio stream @a stream, with each error prefixed by @a prefix, and quit
>> + * iff the @a fatal flag is set. Allocations are performed in the error's
>> + * pool.
>> + */
>> +void svn_handle_error2 (svn_error_t *error,
>> + FILE *stream,
>> + svn_boolean_t fatal,
>> + const char *prefix);
>> +
>> +/** Like @c svn_handle_error2 but with @c prefix set to "svn: "
>> */
>> void svn_handle_error (svn_error_t *error,
>> FILE *stream,
>> svn_boolean_t fatal);
>>
>> -/** Basic, default warning handler.
>> +/** @since New in 1.2
>> *
>> - * Just prints @a error to the stdio stream given in @a stream. Allocations
>> - * are performed in the error's pool.
>> + * Very basic default warning handler: print out the error @a error to the
>> + * stdio stream @a stream, prefixed by @a prefix. Allocations are
>> + * performed in the error's pool.
>> + */
>> +void svn_handle_warning2 (FILE *stream, svn_error_t *error, const char *prefix);
>> +
>> +/** Like @c svn_handle_warning2 but with @c prefix set to "svn: "
>> */
>> void svn_handle_warning (FILE *stream, svn_error_t *error);
>
> This is a _very_ minor nit, but: it might be a bit more intuitive for
> the prefix to come right before the error itself, in the parameter
> list. Especially in svn_handle_error2(), it feels odd that the prefix
> comes last, after even the 'fatal' flag.

Hmm, I don't see any great benefit in changing the order of the
parameters, although I won't object if someone else does it.

-- 
Philip Martin
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Apr 4 18:39:29 2005

This is an archived mail posted to the Subversion Dev mailing list.