[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r13866 - in trunk: contrib/client-side/svn-push subversion/include subversion/libsvn_subr subversion/svnadmin subversion/svndumpfilter subversion/svnlook subversion/svnserve subversion/svnversion subversion/tests subversion/tests/libsvn_delta subversion/tests/libsvn_diff subversion/tests/libsvn_subr tools/examples

From: <kfogel_at_collab.net>
Date: 2005-04-04 16:46:39 CEST

philip@tigris.org writes:
> --- trunk/subversion/include/svn_error.h (original)
> +++ trunk/subversion/include/svn_error.h Sat Apr 2 19:49:28 2005
> @@ -152,17 +152,33 @@
> void svn_error_clear (svn_error_t *error);
>
>
> -/** Very basic default error handler: print out error stack, and quit
> - * iff the @a fatal flag is set.
> +/** @since New in 1.2
> + *
> + * Very basic default error handler: print out error stack @a error to the
> + * stdio stream @a stream, with each error prefixed by @a prefix, and quit
> + * iff the @a fatal flag is set. Allocations are performed in the error's
> + * pool.
> + */
> +void svn_handle_error2 (svn_error_t *error,
> + FILE *stream,
> + svn_boolean_t fatal,
> + const char *prefix);
> +
> +/** Like @c svn_handle_error2 but with @c prefix set to "svn: "
> */
> void svn_handle_error (svn_error_t *error,
> FILE *stream,
> svn_boolean_t fatal);
>
> -/** Basic, default warning handler.
> +/** @since New in 1.2
> *
> - * Just prints @a error to the stdio stream given in @a stream. Allocations
> - * are performed in the error's pool.
> + * Very basic default warning handler: print out the error @a error to the
> + * stdio stream @a stream, prefixed by @a prefix. Allocations are
> + * performed in the error's pool.
> + */
> +void svn_handle_warning2 (FILE *stream, svn_error_t *error, const char *prefix);
> +
> +/** Like @c svn_handle_warning2 but with @c prefix set to "svn: "
> */
> void svn_handle_warning (FILE *stream, svn_error_t *error);

This is a _very_ minor nit, but: it might be a bit more intuitive for
the prefix to come right before the error itself, in the parameter
list. Especially in svn_handle_error2(), it feels odd that the prefix
comes last, after even the 'fatal' flag.

I looked long and hard through the rest of this commit for something
to complain about, and found nothing. Dang :-).

-Karl

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Apr 4 17:14:44 2005

This is an archived mail posted to the Subversion Dev mailing list.