[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r13866 - in trunk: contrib/client-side/svn-push subversion/include subversion/libsvn_subr subversion/svnadmin subversion/svndumpfilter subversion/svnlook subversion/svnserve subversion/svnversion subversion/tests subversion/tests/libsvn_delta subversion/tests/libsvn_diff subversion/tests/libsvn_subr tools/examples

From: <kfogel_at_collab.net>
Date: 2005-04-04 21:49:11 CEST

Philip Martin <philip@codematters.co.uk> writes:
> > This is a _very_ minor nit, but: it might be a bit more intuitive for
> > the prefix to come right before the error itself, in the parameter
> > list. Especially in svn_handle_error2(), it feels odd that the prefix
> > comes last, after even the 'fatal' flag.
>
> Hmm, I don't see any great benefit in changing the order of the
> parameters, although I won't object if someone else does it.

Fair enough; ball in my court :-).

-Karl

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Apr 4 22:21:04 2005

This is an archived mail posted to the Subversion Dev mailing list.