[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] #2246: repos_get_commit_editor API

From: C. Michael Pilato <cmpilato_at_collab.net>
Date: 2005-03-29 01:04:59 CEST

Greg Hudson <ghudson@MIT.EDU> writes:

> On Mon, 2005-03-28 at 13:07, C. Michael Pilato wrote:
> > Right, with (what was actually) my suggestion, passing NULL would not
> > accomplish either of these things. That's ... the point (that makes
> > the code behave exactly as it does today). Clkao's code would instead
> > make his own txn, then pass that (non-NULL) txn to this commit editor.
> > The commit editor would recognize that it was provided a txn, that it
> > doesn't "own" that txn, and so would neither create a new txn, nor
> > destroy the one provided it.
> Aha! That's much clearer. I like that better than having two
> get-commit-editor variants.

Good. I'm coding this now.

To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Mar 29 01:40:40 2005

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.