[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Keywords as hash - final code patch

From: Max Bowsher <maxb_at_ukf.net>
Date: 2005-03-21 22:38:14 CET

Julian Foad wrote:
> Max Bowsher wrote:
>> I've started reviewing (and making numerous tweaks) to this monster.
> So have I. John, you have addressed most but not all of the points I made
> last time. I am finding some more issues, mainly just descriptive (no
> bugs
> yet apart from the one in svn_subst_keywords_differ2).

Yes, I found that one too.

> Max, I think you are hinting (when you say "making numerous tweaks") that
> we
> can save John some time and effort by making our changes for him and
> posting
> the revised version, since he has worked and waited for so long already.
> If
> more than one of us does that at once it will get difficult to merge, so
> I'll
> just post my review as usual when I get through it, which might be a few
> days
> from now, and then maybe take your version and add my tweaks to it.

I've made quite substantial alterations now, but I've been confining my
initial work to just the include and libsvn_subr parts of the patch. i.e.
these three files:

* subversion/includes/svn_subst.h:
* subversion/includes/svn_types.h:
* subversion/libsvn_subr/svn_subst.c:

Could you could post your review of that section before the rest, please?

Then I will reconcile my tweaks with it, and make sure to explicitly
organize who is working on what, going forward.



To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Mar 22 00:37:55 2005

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.