Re: [PATCH] Keywords as hash - final code patch

Max Bowsher wrote:
> I've started reviewing (and making numerous tweaks) to this monster.

So have I. John, you have addressed most but not all of the points I made last
time. I am finding some more issues, mainly just descriptive (no bugs yet
apart from the one in svn_subst_keywords_differ2).

Max, I think you are hinting (when you say "making numerous tweaks") that we
can save John some time and effort by making our changes for him and posting
the revised version, since he has worked and waited for so long already. If
more than one of us does that at once it will get difficult to merge, so I'll
just post my review as usual when I get through it, which might be a few days
from now, and then maybe take your version and add my tweaks to it.

- Julian

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Mar 22 00:38:17 2005