Re: [PATCH] Keywords as hash - final code patch

Max Bowsher wrote:
> Julian Foad wrote:
>> yet apart from the one in svn_subst_keywords_differ2).
>
>
> Yes, I found that one too.

I'm guessing you mean this chunk:

+ if (((a == NULL) && (b == NULL)) /* no A or B */
+ || ((a == NULL) && (b != NULL)) /* no A but B */
+ || ((a != NULL) && (b == NULL)) /* no B but A */
+ /* Unequal number of contents */
+ || (apr_hash_count(lame_a) != apr_hash_count(lame_b)))
      {
- return FALSE;
+ return TRUE;

and I realize that the first line does look wrong now that I look at it
again. As you can probably tell, I was trying to cover all possible
bases and got carried away...

> I've made quite substantial alterations now, but I've been confining my
> initial work to just the include and libsvn_subr parts of the patch.
> i.e. these three files:

I look forward to seeing your changes so that I may improve my next
patch submission...

John

-- 
John Peacock
Director of Information Research and Technology
Rowman & Littlefield Publishing Group
4501 Forbes Boulevard
Suite H
Lanham, MD  20706
301-459-3366 x.5010
fax 301-429-5748
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org