[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Keywords as hash - final code patch

From: Max Bowsher <maxb_at_ukf.net>
Date: 2005-03-21 23:13:14 CET

John Peacock wrote:
> Max Bowsher wrote:
>> Julian Foad wrote:
>>> yet apart from the one in svn_subst_keywords_differ2).
>>
>>
>> Yes, I found that one too.
>
> I'm guessing you mean this chunk:
>
> + if (((a == NULL) && (b == NULL)) /* no A or B */
> + || ((a == NULL) && (b != NULL)) /* no A but B */
> + || ((a != NULL) && (b == NULL)) /* no B but A */
> + /* Unequal number of contents */
> + || (apr_hash_count(lame_a) != apr_hash_count(lame_b)))
> {
> - return FALSE;
> + return TRUE;
>
> and I realize that the first line does look wrong now that I look at it
> again. As you can probably tell, I was trying to cover all possible
> bases and got carried away...

Err, no, I mean the way it gratuitously assumes that just because the two
hashes have the same number of keys, all those keys must be equal!

Max.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Mar 22 00:36:27 2005

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.