Hello Philip, hello everybody else,
I love svn blame - have I ever said that? :-)
On Friday 18 March 2005 18:57, Philip Martin wrote:
> "Ph. Marek" <philipp.marek@bmlv.gv.at> writes:
> > --- subversion/libsvn_client/client.h (revision 231)
> > +++ subversion/libsvn_client/client.h (revision 232)
> > ...
> Your implementation never sets *PROPERTIES to NULL. I don't know
> whether you made a mistake with the comment or the implementation.
If you take a nearer look you'll see that I copied
svn_client__get_auto_props mostly one-to-one - that's where the comments
come from.
8932 kfogel 2004-03-08 18:32:40 +0100 (Mon, 08 Mar 2004) /* Read automatic properties matching PATH from CT
8932 kfogel 2004-03-08 18:32:40 +0100 (Mon, 08 Mar 2004) Set *PROPERTIES to a hash containing propname/v
8932 kfogel 2004-03-08 18:32:40 +0100 (Mon, 08 Mar 2004) (const char * keys mapping to svn_string_t * va
8932 kfogel 2004-03-08 18:32:40 +0100 (Mon, 08 Mar 2004) auto-props are disabled, set *PROPERTIES to NUL
8932 kfogel 2004-03-08 18:32:40 +0100 (Mon, 08 Mar 2004) Set *MIMETYPE to the mimetype, if any, or to NU
8932 kfogel 2004-03-08 18:32:40 +0100 (Mon, 08 Mar 2004) Allocate the hash table, keys, values, and mime
8839 cmpilato 2004-02-25 23:57:41 +0100 (Wed, 25 Feb 2004) svn_error_t *svn_client__get_auto_props (apr_hash_
8839 cmpilato 2004-02-25 23:57:41 +0100 (Wed, 25 Feb 2004) const cha
8839 cmpilato 2004-02-25 23:57:41 +0100 (Wed, 25 Feb 2004) const cha
8839 cmpilato 2004-02-25 23:57:41 +0100 (Wed, 25 Feb 2004) svn_clien
8839 cmpilato 2004-02-25 23:57:41 +0100 (Wed, 25 Feb 2004) apr_pool_
> > --- subversion/libsvn_client/add.c (revision 231)
> > +++ subversion/libsvn_client/add.c (revision 232)
> > ...
> > + /* initialisation */
>
> A pointless comment.
7321 julianfoad 2003-10-07 14:24:48 +0200 (Tue, 07 Oct 2003) /* initialisation */
BTW: is "annotate" the politically correct way?
But never mind - I'll change the comments, if you like.
> New functionality like this should have some regression tests.
That's true. But I don't know python, so I believe it would be much
faster if someone who did adds them.
Shall I commit this (with changed or the original comments?) -
please vote or just tell me yes/no.
Regards,
Phil
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Mar 21 07:18:02 2005