Re: new experimental branch: dir-auto-props (issue 1989)

"Ph. Marek" <philipp.marek@bmlv.gv.at> writes:

> On Friday 18 March 2005 18:57, Philip Martin wrote:
>> "Ph. Marek" <philipp.marek@bmlv.gv.at> writes:
>> > --- subversion/libsvn_client/client.h (revision 231)
>> > +++ subversion/libsvn_client/client.h (revision 232)
>> > ...
>> Your implementation never sets *PROPERTIES to NULL. I don't know
>> whether you made a mistake with the comment or the implementation.
> If you take a nearer look you'll see that I copied
> svn_client__get_auto_props mostly one-to-one - that's where the comments
> come from.

That doesn't make the bug acceptable.

> But never mind - I'll change the comments, if you like.

That would make the function match it's documentation, but it would
not fix the code that calls the function. Although the code would
work it would also have pointless checks mandated by the old
documentation.

>> New functionality like this should have some regression tests.
> That's true. But I don't know python, so I believe it would be much
> faster if someone who did adds them.

I'm concerned with how long it takes for the tests appear in the tree,
not how long it takes you to write them. I suspect that if we wait
for someone else to add them it will take much longer to get into the
tree.

> Shall I commit this (with changed or the original comments?) -
> please vote or just tell me yes/no.

Don't commit the original patch. If you have a new patch then post it
for review.

-- 
Philip Martin
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org