Re: Ruby: _Buildsystem_ changes ok to merge to trunk, I think - go ahead?

In <099901c52d5d$fc3928a0$e6ec6f83@robinson.cam.ac.uk>
  "Max Bowsher" <maxb@ukf.net> wrote:

> A question for Kouhei Sutou:
>
> What should we do about this?
>
> + AC_CACHE_CHECK([how to compile Ruby extensions],
> [svn_cv_ruby_compile],[
> + # XXX: This apparent temporary kludge needs to be resolved
> + # I assume we *should* be using CFLAGS from Ruby
> + svn_cv_ruby_compile="`$RUBY -rrbconfig -e 'print
> Config::CONFIG.fetch(%q(CC))'` -g \$(SWIG_RB_INCLUDES)"
> + # svn_cv_ruby_compile="`$RUBY -rrbconfig -e 'print
> Config::CONFIG.fetch(%q(CC)), %q( ), Config::CONFIG.fetch(%q(CFLAGS))'`
> \$(SWIG_RB_INCLUDES)"
> + ])

I have the feeling that I have a trouble which is caused by
including "Config::CONFIG.fetch(%q(CFLAGS))" before. But now
I can't find any problem caused by this. So I think we
should use

> + # svn_cv_ruby_compile="`$RUBY -rrbconfig -e 'print
> Config::CONFIG.fetch(%q(CC)), %q( ), Config::CONFIG.fetch(%q(CFLAGS))'`

instead of

> + svn_cv_ruby_compile="`$RUBY -rrbconfig -e 'print
> Config::CONFIG.fetch(%q(CC))'` -g \$(SWIG_RB_INCLUDES)"

Cheers,

--
kou
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org