[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Attn pmarek: Please revise the log message for r13261

From: Julian Foad <julianfoad_at_btopenworld.com>
Date: 2005-03-15 20:34:03 CET

Ph. Marek wrote:
> I've gone through the svn:log messages and cleaned them up.


> If I've forgotten something, let me know.

In parentheses, you should give the symbols that are affected
(added/deleted/modified), so:

> r13261 | pmarek | 2005-03-04 12:46:06 +0000 (Fri, 04 Mar 2005) | 49 lines
> Applied the patch-ownergroupmode-1.1.3-1.patch.
> * subversion/include/svn_io.h
> Declarations of helper functions
> svn_io_file_owner_string
> svn_io_file_group_string
> svn_io_file_mode_string
> svn_io_file_set_file_owner_group_mode

    "(svn_io_file_owner_string, svn_io_file_group_string,
      svn_io_file_mode_string, svn_io_file_set_file_owner_group_mode):
       New functions."

(The phrase "helper function" is generally used to mean a local (private)
function that is a subroutine for some other function(s).)

> * subversion/include/svn_props.h
> Definitions of new property names


> * subversion/libsvn_client/commit.c
> (import_file): Change auto-props to the correct value
> * subversion/libsvn_client/commit_util.c
> (harvest_committables): Do the stat() on the file once and
> use the values for the properties text-time, owner, group
> and mode, if these are set.
> * subversion/libsvn_client/export.c
> (copy_versioned_files): Fetch and save the svn:text-time property

"copy_versioned_files" doesn't seem to have been changed; instead
"copy_one_versioned_file" has been changed.

Also, the structure "file_baton" has been changed but isn't mentioned here.

> (change_file_prop): and use it to override the commit-timestamp
> (close_file):

Missing description.

> * subversion/libsvn_client/repos_diff.c
> Define a static helper function populate_finfo()

    "(populate_finfo): New helper function."

Also, the structure "file_baton" has been changed but isn't mentioned here.

> (change_file_prop): Uses populate_finfo to record property changes
> * subversion/libsvn_subr/io.c
> (svn_io_files_contents_same_p):

That function isn't changed in any meaningful way. (It just had some spaces
changed to a tab, which you should try to avoid doing.)

> Definitions of helper functions
> svn_io_file_owner_string: convert a userid to a string
> svn_io_file_group_string: convert a groupid to a string
> svn_io_file_mode_string: convert a unix-mode to a string
> svn_io_file_set_file_owner_group_mode: use the property values
> to set the file's meta-data

    "(svn_io_file_owner_string): New function to convert a userid to a string.
     (svn_io_file_group_string): New function to convert a groupid to a string.
     (svn_io_file_mode_string): New function to convert a unix-mode to a string.
     (svn_io_file_set_file_owner_group_mode): New function to use the property
       values to set the file's meta-data."

or just

    "(svn_io_file_owner_string, svn_io_file_group_string,
      svn_io_file_mode_string, svn_io_file_set_file_owner_group_mode):
       New functions."

if you prefer.

> * subversion/libsvn_wc/adm_crawler.c
> (restore_file):
> * subversion/libsvn_wc/adm_ops.c
> (revert_admin_things): Use the properties svn:owner, svn:group, and
> svn:unix-mode to set the new file attributes.
> * subversion/libsvn_wc/update_editor.c
> (change_file_prop): Save the properties owner, group, mode
> (close_file): and use them to restore the meta-data

"close_file" doesn't appear to have been changed at all.

Also, the structure "file_baton" has been changed but isn't mentioned here.

- Julian

To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Mar 15 20:36:12 2005

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.