On Tuesday 15 March 2005 20:34, Julian Foad wrote:
> Ph. Marek wrote:
> > If I've forgotten something, let me know.
>
> In parentheses, you should give the symbols that are affected
ok.
> (added/deleted/modified), so:
> > r13261 | pmarek | 2005-03-04 12:46:06 +0000 (Fri, 04 Mar 2005) | 49 lines
> >
> > Applied the patch-ownergroupmode-1.1.3-1.patch.
> >
> > * subversion/include/svn_io.h
> > Declarations of helper functions
> > svn_io_file_owner_string
> > svn_io_file_group_string
> > svn_io_file_mode_string
> > svn_io_file_set_file_owner_group_mode
>
> "(svn_io_file_owner_string, svn_io_file_group_string,
> svn_io_file_mode_string, svn_io_file_set_file_owner_group_mode):
> New functions."
>
> (The phrase "helper function" is generally used to mean a local (private)
> function that is a subroutine for some other function(s).)
done
> > * subversion/include/svn_props.h
> > Definitions of new property names
>
> "(SVN_PROP_OWNER, SVN_PROP_GROUP, SVN_PROP_UNIX_MODE): New property
> names."
done
> > * subversion/libsvn_client/commit.c
> > (import_file): Change auto-props to the correct value
> >
> > * subversion/libsvn_client/commit_util.c
> > (harvest_committables): Do the stat() on the file once and
> > use the values for the properties text-time, owner, group
> > and mode, if these are set.
> >
> > * subversion/libsvn_client/export.c
> > (copy_versioned_files): Fetch and save the svn:text-time property
>
> "copy_versioned_files" doesn't seem to have been changed; instead
> "copy_one_versioned_file" has been changed.
done - diff -p seems to have given the wrong function name.
> Also, the structure "file_baton" has been changed but isn't mentioned here.
done.
> > (change_file_prop): and use it to override the commit-timestamp
> > (close_file):
>
> Missing description.
well, I meant that all three function do this: get the properties, and set
them. Have clarified.
> > * subversion/libsvn_client/repos_diff.c
> > Define a static helper function populate_finfo()
>
> "(populate_finfo): New helper function."
>
> Also, the structure "file_baton" has been changed but isn't mentioned here.
done, some more info applied.
> > (change_file_prop): Uses populate_finfo to record property changes
> >
> > * subversion/libsvn_subr/io.c
> > (svn_io_files_contents_same_p):
>
> That function isn't changed in any meaningful way. (It just had some
> spaces changed to a tab, which you should try to avoid doing.)
Sorry. I mostly do a "diff -w", so I didn't see this.
> > Definitions of helper functions
> > svn_io_file_owner_string: convert a userid to a string
> > svn_io_file_group_string: convert a groupid to a string
> > svn_io_file_mode_string: convert a unix-mode to a string
> > svn_io_file_set_file_owner_group_mode: use the property values
> > to set the file's meta-data
>
> "(svn_io_file_owner_string): New function to convert a userid to a
> string. (svn_io_file_group_string): New function to convert a groupid to a
> string. (svn_io_file_mode_string): New function to convert a unix-mode to a
> string. (svn_io_file_set_file_owner_group_mode): New function to use the
> property values to set the file's meta-data."
done
> or just
>
> "(svn_io_file_owner_string, svn_io_file_group_string,
> svn_io_file_mode_string, svn_io_file_set_file_owner_group_mode):
> New functions."
>
> if you prefer.
>
> > * subversion/libsvn_wc/adm_crawler.c
> > (restore_file):
> > * subversion/libsvn_wc/adm_ops.c
> > (revert_admin_things): Use the properties svn:owner, svn:group, and
> > svn:unix-mode to set the new file attributes.
> >
> > * subversion/libsvn_wc/update_editor.c
> > (change_file_prop): Save the properties owner, group, mode
> > (close_file): and use them to restore the meta-data
>
> "close_file" doesn't appear to have been changed at all.
you're right - a part of the patch file hasn't been applied.
But that's no longer needed as the current version has moved this part into
install_file.
what shall I do with this part? shall I write something like "part of patch
not applied, updated by rev xxxx" or just delete this line?
> Also, the structure "file_baton" has been changed but isn't mentioned here.
done.
> - Julian
Regards,
Phil
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Mar 16 08:08:19 2005