Re: [PATCH] Issue #2219 - Canonicalize values in svn:keywords - v3

On Thu, 2005-03-10 at 21:40, Julian Foad wrote:
> Madan U Sreenivasan wrote:
> > On Wed, 2005-03-09 at 22:54, Julian Foad wrote:
> >>Could you please factor out some of this repetition? It's hard to review as it is.
> >
> > Repetition? I didnt understand that....
>
> The list of keywords to test is repeated: it appears both at the beginning of
> the function and in the tests. It would be better to have just one list of
> keywords to test.
>
[...]
Cool... I understand.... thanks to you for your test case... ( actually
I have one variant of what you have given here....thanks to Sameer) ....
I will put the better of these with the rest of the patch and send it
across.....

Thanks again for the efforts reg the test case.... makes me want to
learn more python.... :-)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Mar 11 08:55:08 2005