[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Issue #2219 - Canonicalize values in svn:keywords - v3

From: Madan U Sreenivasan <madan_at_collab.net>
Date: 2005-03-10 05:44:48 CET

On Wed, 2005-03-09 at 22:54, Julian Foad wrote:
> I just have some comments on formatting, for the C code, and a couple of
> comments about the Python tests.
> Madan U Sreenivasan wrote:
> > [[[
> > Fixed Issue #2219: Canonicalize values in svn:keywords

> Could you please factor out some of this repetition? It's hard to review as it is.

Repetition? I didnt understand that....
Anyways, I will try to make the code look better....

> In the "HeadURL" block, every "if" says "if not", whereas in the other blocks
> there is a pair of "if <capitalised>" and "if not <lower-case>". That looks
> suspicious.
Suspicious? maybe, but not wrong.... ;-)

Everything else look valid. I will correct them. Thanks for the
exhaustive feedback...


To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Mar 10 05:38:36 2005

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.