Re: [PATCH] issue 1954 - v3

Peter N. Lundblad wrote:
> On Tue, 14 Dec 2004, VK Sameer wrote:
> + * returns SVN_NO_ERROR if valid
> + * returns SVN_ERR_FS_PATH_SYNTAX if invalid
>
> Not sure how this will be formatted in the doxygen output. I assume it
> won't take the line breaks into account, but I haven't checked.

Also, write "@c" before each symbol (other function names, constants like
SVN_NO_ERROR, etc.) to mark it for cross-reference.

> + return svn_error_createf (SVN_ERR_FS_PATH_SYNTAX, NULL,
> + "Invalid control char. '%x' in path '%s'",
> + *c,
> + svn_path_local_style (path, pool));

I recommend '0x%02X' for printing in hexadecimal, to give '0x0A' for a
line-feed, rather than just 'A'. At least zero-pad it and give some indication
that it is hex rather than, say, ASCII mnemonic.

- Julian

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Dec 14 13:33:48 2004