[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] svnlook --revprop patch, take two

From: Julian Foad <julianfoad_at_btopenworld.com>
Date: 2004-12-14 14:07:13 CET

Oliver Klozoff wrote:
> This patch adds --revprop support to svnlook propget and svnlook proplist.
> It also adds more basic regression tests for other svnlook subcommands.

I would adjust your log message to use only two spaces for indentation, and as
follows, and start with a summary based on your introduction above:

> --- log-message-worthy content follows ---

Add --revprop support to 'svnlook propget' and 'svnlook proplist'.
Add basic regression tests for these and other svnlook subcommands.

> * subversion/svnlook/main.c
> (subcommand_plist, subcommand_pget):
> Changed to pass NULL for the path argument to do_plist/do_pget

! Pass NULL for the 'path' argument to do_plist/do_pget

> when --revprop is specified.
> (do_plist, do_pget):
> When the 'path' argument is NULL, switch from svn_fs_node_proplist/
> svn_fs_node_prop to svn_fs_revision_proplist/svn_fs_revision_prop.
> * subversion/tests/clients/cmdline/svnlook_tests.py
> Added the following tests:
> test_propget_revprop (tests svnlook propget --revprop)
> test_propget_revprop_missing (tests svnlook --revprop
> for a revision property that doesn't exist)
> test_proplist_revprop (tests svnlook proplist --revprop)
> test_uuid (tests svnlook uuid)
> test_logmsg (tests svnlook log)
> test_author (tests svnlook author)

* subversion/tests/clients/cmdline/svnlook_tests.py
   (test_propget_revprop): New. Tests 'svnlook propget --revprop'.
   (test_propget_revprop_missing): New. Tests 'svnlook --revprop'
     for a revision property that doesn't exist.
   (test_proplist_revprop): New. Tests 'svnlook proplist --revprop'.
   (test_uuid): New. Tests 'svnlook uuid'.
   (test_logmsg): New. Tests 'svnlook log'.
   (test_author): New. Tests 'svnlook author'.
   (test_list): Add the new tests.

Or just

* subversion/tests/clients/cmdline/svnlook_tests.py
   (test_propget_revprop, test_propget_revprop_missing, test_proplist_revprop,
    test_uuid, test_logmsg, test_author): New.
   (test_list): Add the new tests.

> * subversion/tests/clients/cmdline/svntest/main.py
> Created function 'run_command_stdin'. Just like 'run_command',

! (run_command_stdin): New. Just like 'run_command',

> except it allows the caller to specify data to be piped into
> the command's stdin (needed by 'test_uuid').

- Julian

To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Dec 14 14:08:21 2004

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.