Re: [PATCH] issue 1954 - v3

On Tue, 2004-12-14 at 18:02, Julian Foad wrote:

> Also, write "@c" before each symbol (other function names, constants like
> SVN_NO_ERROR, etc.) to mark it for cross-reference.

Added in the latest version of the patch sent to dev@.

> > + return svn_error_createf (SVN_ERR_FS_PATH_SYNTAX, NULL,
> > + "Invalid control char. '%x' in path '%s'",
> > + *c,
> > + svn_path_local_style (path, pool));
>
> I recommend '0x%02X' for printing in hexadecimal, to give '0x0A' for a
> line-feed, rather than just 'A'. At least zero-pad it and give some indication
> that it is hex rather than, say, ASCII mnemonic.

Done. It was there initially - got removed during vain attempts at
staying within 72 cols.

Thanks
Sameer

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Dec 15 01:47:47 2004