[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn_path_canonicalize() broken in 1.1.x on cygwin (was: SVN 1.1.1: Cannot find .subversion folder (CYGWIN) on users@)

From: Branko Čibej <brane_at_xbc.nu>
Date: 2004-10-27 07:50:23 CEST

Roland Schwingel wrote:

> Hi...
> Yesterday I posted the attached observation to the users list...I did
> some further investigations.
> As of the fact that IMHO this is a bug in the implementation I am
> switching to the developers list.
> To summarize:
> Subversion 1.1.x can not find the users .subversion folder in his/her
> homeaccount on cygwin when
> the homeaccount resides on an UNC share.
> Subversion 1.0.9 is like 1.0.4 not showing the behaviour. Everything
> is fine. So I was taking a look
> in the code. apr is identical in 1.0.9 and 1.1.1. So it couldn't be
> the failing instance here. So I looked further
> and found that svn_path_canonicalize() in
> subversion/libsvn_subr/path.c is broken in 1.1.x when running
> on cygwin and getting an UNC path.
> Example:
> //server/share/folder
> will result in
> /server/share/folder
> after svn_path_canonicalize()
> The reason for it is that the leading / gots stripped here. There is
> an #ifdef for win32
> taking care of double leading seperators but not for cygwin.
> So replacing the 2 occurencies of
> #ifdef WIN32
> in svn_path_canonicalize() with
> #if defined(WIN32) || defined(CYGWIN)
> fixed the problem for me. I attached a patch for this problem basing
> on the current 1.1.1 release code
> I haven't read the HACKING file so this is just a suggestion how it
> can be fixed .Feel free to ignore
> it and use another solution for this if you find it better suitable.
> I also dared and filed an issue for this (#2108).

You dare a lot. :-)

Yes, it's defintely a bug, and I think the solution is accetpable given
that there already is an ifdef there.

So, please read HACKING and add a log message for your patch.


-- Brane

To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Oct 27 07:50:20 2004

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.