Re: Proposed New Feature (SVNROOT)

tbrowder@cox.net wrote:
> I previously asked about a feature like CVSROOT (to be called
> SVNROOT).
>
> I have attempted to add that feature and have attached proposed code
> changes in the form of diffs from the latest subversion tree.

I probably wasn't around for the earlier discussion on SVNROOT (but I
probably were for some previous incarnation of it in the past), but in
any case, it would be very good to explain the usage of the new
feature in the mail - and not just inside the patch in code comments.

And unless the extent of the functionality was already discussed (like
I assume it wasn't from the patch), I strongly would urge you to
discuss the actual semantics of SVNROOT on the list first, get a
consensus on what would be sane behaviour, and hopefully start coding
after you've got a green light that this indeed is a wanted change.

Right now, the patch changes only 'checkout' and 'import' to use
SVNROOT, and even there the use cases are a bit odd. If something like
this is implemented, it needs to be with a clean and consistent
interface.

Other comments on the patch (aside from the ones already said):

 * There should be more description on the command-line help, and
   descriptions on all changed commands.

 * As by HACKING, you should not put your name in a comment.

 * Consider using apr_psprintf instead of sprintf.

 * Consider providing test cases for the new functionality.

Please do not be put off by the commentary received if you indeed are
serious about getting SVNROOT functionality into Subversion. Instead
let's work out the issues together so everyone will benefit.

-- Naked

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Mar 16 22:51:58 2004