Re: svn commit: r9033 - trunk/subversion/libsvn_ra_svn

On Sun, 2004-03-14 at 12:52, Philip Martin wrote:
> > On Sat, 2004-03-13 at 16:56, philip@tigris.org wrote:
> >> - SVN_CMD_ERR(ds->editor->delete_entry(path, rev, entry->baton, entry->pool));
> >> + subpool = svn_pool_create(entry->pool);
> >> + SVN_CMD_ERR(ds->editor->delete_entry(path, rev, entry->baton, subpool));
> >> + apr_pool_destroy(subpool);
> >> return SVN_NO_ERROR;
> >
> > Um, why not just use "pool" here?
>
> Because editor->delete_entry allocates a non-trivial amount of memory
> and using a subpool allows that memory to be deallocated.

But "pool" is already a per-command subpool (whereas entry->pool is only
a per-directory subpool).

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sun Mar 14 18:54:36 2004