[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r9033 - trunk/subversion/libsvn_ra_svn

From: Philip Martin <philip_at_codematters.co.uk>
Date: 2004-03-14 18:52:11 CET

Greg Hudson <ghudson@MIT.EDU> writes:

> On Sat, 2004-03-13 at 16:56, philip@tigris.org wrote:
>> - SVN_CMD_ERR(ds->editor->delete_entry(path, rev, entry->baton, entry->pool));
>> + subpool = svn_pool_create(entry->pool);
>> + SVN_CMD_ERR(ds->editor->delete_entry(path, rev, entry->baton, subpool));
>> + apr_pool_destroy(subpool);
>> return SVN_NO_ERROR;
>
> Um, why not just use "pool" here?

Because editor->delete_entry allocates a non-trivial amount of memory
and using a subpool allows that memory to be deallocated.

-- 
Philip Martin
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sun Mar 14 18:52:31 2004

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.