[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

[PATCH] Bug in libsvn_fs/db: fold_change

From: Max Bowsher <maxb_at_ukf.net>
Date: 2004-03-14 19:05:02 CET

This is the bug which causes some cvs2svn-produced repositories to gain
spurious additional files when passed through a dump-load cycle.

[[[
* subversion/libsvn_fs/bdb/changes-table.c (fold_change):
    The sequence "replace, delete" should fold to "delete", not "no-op".
]]]

[[[
Index: subversion/libsvn_fs/bdb/changes-table.c
===================================================================
--- subversion/libsvn_fs/bdb/changes-table.c (revision 9043)
+++ subversion/libsvn_fs/bdb/changes-table.c (working copy)
@@ -168,12 +168,10 @@
           break;

         case svn_fs_path_change_delete:
- if ((old_change->change_kind == svn_fs_path_change_replace)
- || (old_change->change_kind == svn_fs_path_change_add))
+ if (old_change->change_kind == svn_fs_path_change_add)
             {
- /* If the path was introduced in this transaction via an
- add or replace, and we are deleting it, just remove
- the path altogether. */
+ /* If the path was introduced in this transaction via an add,
+ * and we are deleting it, just remove the path altogether.
*/
               old_change = NULL;
             }
           else
]]]

Max.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sun Mar 14 19:05:32 2004

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.