Re: [PATCH] Fix reverting a replacement without properties.

Ben Reser <ben@reser.org> writes:

> Patch from Ben Reser <ben@reser.org>
>
> * subversion/libsvn_wc/adm_ops.c
> (revert_admin_things): Actually check the results of svn_io_check_path()
> before trying to copy base-props to props when reverting a replacement.

It's a long standing anomaly that added/committed files doesn't have
props or props-base files, if it did then this check would not be
necessary. Perhaps it would be better to make added/committed files
have props and prop-base files? Although given the tortured state of
libsvn_wc your minimal change might be a better choice.

> Someone should probably write a test for this. But I don't really
> understand how to write the test for this. If someone wants to walk me
> through it I'll update the patch to have a test.

Write a new test in one of tests/clients/cmdline/*py and add it to the
test_list in that file. Have the new test do the following: make a
sandbox, "svn add" a file, run_and_verify_commit, "svn delete" the
file, run_and_verify_status, "svn revert" the file and finally
run_and_verify_status again.

-- 
Philip Martin
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org