Re: [PATCH] Fix reverting a replacement without properties.

On Tue, Mar 02, 2004 at 02:59:18PM +0000, Philip Martin wrote:
> It's a long standing anomaly that added/committed files doesn't have
> props or props-base files, if it did then this check would not be
> necessary. Perhaps it would be better to make added/committed files
> have props and prop-base files? Although given the tortured state of
> libsvn_wc your minimal change might be a better choice.

I started out trying to do just this. My initial thought was without
having that file there ws no way to be sure it wasn't accidentally
deleted.

But after fiddling with it for a while and not really getting anywhere a
couple of things occurred to me:

a) People have complained about the number of (empty) files that our
admin area takes up. My guess is that a lot of files don't have
properties on them. This would only increase the number.

b) Having an empty file doesn't really prevent accidental changes to the
admin area. I can just as easily modify the file. And we already have
a prop-time entry in entries to help with that.

c) Was proving to be much more difficult to actually do.

So I went with the easier solution.

> Write a new test in one of tests/clients/cmdline/*py and add it to the
> test_list in that file. Have the new test do the following: make a
> sandbox, "svn add" a file, run_and_verify_commit, "svn delete" the
> file, run_and_verify_status, "svn revert" the file and finally
> run_and_verify_status again.

I started to do that and didn't quite understand what the tests were
actually doing. Your explanation helps make some sense of it. I'll see
what I can do about this in a little bit.

-- 
Ben Reser <ben@reser.org>
http://ben.reser.org
"Conscience is the inner voice which warns us somebody may be looking."
- H.L. Mencken
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org